Java: Move non-experimental models out of the experimental folder. #17952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
added
the
no-change-note-required
aschackmull
approved these changes
Nov 11, 2024
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
I think it's probably fine to keep them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a basic re-factor as we just move some non-experimental models out of the experimental folder.
However, it is a bit unclear, whether these models should have been added as experimental models and only activated for a specific set of queries (this was my immediate impression, but there are a commit message that contradicts this assumption). All the models were added together with experimental queries, but there is a commit message which indicates that it is intentional that they are non-experimental (at least for some models): 7e5f2e2
Should we go ahead and keep them in production or is this something that needs to be corrected by demoting the models to experimental?