Skip to content

Conversation

redsun82
Copy link
Contributor

Not being triggered by changes in shared was making it possible to not notice changes in shared having effect on Swift tests. For example this PR introduced a test change that was fixed here.

Not being triggered by changes in shared was making it possible to not
notice changes in `shared` having effect on Swift tests. For example
[this PR](#15501) introduced a
test change that was fixed [here](#16197).
@redsun82 redsun82 requested a review from MathiasVP April 12, 2024 13:48
@redsun82 redsun82 requested a review from a team as a code owner April 12, 2024 13:48
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@redsun82 redsun82 merged commit 3614d3d into main Apr 12, 2024
@redsun82 redsun82 deleted the redsun82/add-shared-triggers-to-swift-ci branch April 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants