Skip to content

C++: Fix FP in cpp/incorrectly-checked-scanf #15456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

MathiasVP
Copy link
Contributor

Note that, because the cpp/missing-check-scanf query only raises an alert if cpp/incorrectly-checked-scanf doesn't, by fixing the FP in cpp/incorrectly-checked-scanf we're now moving the alert to the cpp/missing-check-scanf query.

This is a good trade-off since cpp/incorrectly-checked-scanf is a high-precision query, and cpp/missing-check-scanf is only at precision medium.

I tried to fix the FP in cpp/incorrectly-checked-scanf as well, but this is more difficult. So I think we should get this fix in first before trying to fix the cpp/incorrectly-checked-scanf case.

@github-actions github-actions bot added the C++ label Jan 29, 2024
@MathiasVP MathiasVP marked this pull request as ready for review January 29, 2024 13:47
@MathiasVP MathiasVP requested a review from a team as a code owner January 29, 2024 13:47
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if DCA is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants