C++: Fix FP in cpp/incorrectly-checked-scanf
#15456
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that, because the
cpp/missing-check-scanf
query only raises an alert ifcpp/incorrectly-checked-scanf
doesn't, by fixing the FP incpp/incorrectly-checked-scanf
we're now moving the alert to thecpp/missing-check-scanf
query.This is a good trade-off since
cpp/incorrectly-checked-scanf
is a high-precision query, andcpp/missing-check-scanf
is only at precisionmedium
.I tried to fix the FP in
cpp/incorrectly-checked-scanf
as well, but this is more difficult. So I think we should get this fix in first before trying to fix thecpp/incorrectly-checked-scanf
case.