Skip to content

Commit ed5f19b

Browse files
geoffw0mchammer01paldepind
authored
Apply suggestions from code review
Co-authored-by: mc <42146119+mchammer01@users.noreply.github.com> Co-authored-by: Simon Friis Vindum <paldepind@github.com>
1 parent 4b28843 commit ed5f19b

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

rust/ql/src/queries/security/CWE-312/CleartextLogging.qhelp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<overview>
77
<p>
8-
Sensitive user data and system information that is logged could be seen by an attacker when it is
8+
Sensitive user data and system information that is logged could be exposed to an attacker when it is
99
displayed. Also, external processes often store the standard output and standard error streams of
1010
an application, which will include logged sensitive information.
1111
</p>
@@ -23,7 +23,7 @@ The following example code logs user credentials (in this case, their password)
2323
</p>
2424
<sample src="CleartextLoggingBad.rs"/>
2525
<p>
26-
Instead, you should encrypt the credentials, or better still omit them entirely:
26+
Instead, you should encrypt the credentials, or better still, omit them entirely:
2727
</p>
2828
<sample src="CleartextLoggingGood.rs"/>
2929
</example>

rust/ql/test/query-tests/security/CWE-312/test_logging.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use std::fmt::Write as _;
66
// --- tests ---
77

88
fn get_password() -> String {
9-
return "123456".to_string();
9+
"123456".to_string()
1010
}
1111

1212
fn use_password(password: &String) {

0 commit comments

Comments
 (0)