Skip to content

Commit e4edb19

Browse files
Update to hasFullyQualifiedName
1 parent f24c042 commit e4edb19

File tree

1 file changed

+8
-6
lines changed
  • csharp/ql/lib/semmle/code/csharp/frameworks

1 file changed

+8
-6
lines changed

csharp/ql/lib/semmle/code/csharp/frameworks/Razor.qll

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ private import semmle.code.csharp.frameworks.microsoft.AspNetCore
77

88
/** A call to the `View` method */
99
private class ViewCall extends MethodCall {
10-
ViewCall() { this.getTarget().hasQualifiedName("Microsoft.AspNetCore.Mvc", "Controller", "View") }
10+
ViewCall() {
11+
this.getTarget().hasFullyQualifiedName("Microsoft.AspNetCore.Mvc", "Controller", "View")
12+
}
1113

1214
/** Gets the `name` argument to this call, if any. */
1315
string getNameArgument() {
@@ -55,7 +57,7 @@ private class ViewCall extends MethodCall {
5557
string getAreaName() {
5658
exists(Attribute attr |
5759
attr = this.getController().getAnAttribute() and
58-
attr.getType().hasQualifiedName("Microsoft.AspNetCore.Mvc", "AreaAttribute") and
60+
attr.getType().hasFullyQualifiedName("Microsoft.AspNetCore.Mvc", "AreaAttribute") and
5961
result = attr.getArgument(0).(StringLiteral).getValue()
6062
)
6163
}
@@ -70,13 +72,13 @@ class RazorViewClass extends Class {
7072

7173
RazorViewClass() {
7274
exists(Class baseClass | baseClass = this.getBaseClass().getUnboundDeclaration() |
73-
baseClass.hasQualifiedName("Microsoft.AspNetCore.Mvc.Razor", "RazorPage<>")
75+
baseClass.hasFullyQualifiedName("Microsoft.AspNetCore.Mvc.Razor", "RazorPage`1")
7476
or
75-
baseClass.hasQualifiedName("Microsoft.AspNetCore.Mvc.RazorPages", "Page")
77+
baseClass.hasFullyQualifiedName("Microsoft.AspNetCore.Mvc.RazorPages", "Page")
7678
) and
7779
attr.getFile() = this.getFile() and
7880
attr.getType()
79-
.hasQualifiedName("Microsoft.AspNetCore.Razor.Hosting", "RazorCompiledItemAttribute")
81+
.hasFullyQualifiedName("Microsoft.AspNetCore.Razor.Hosting", "RazorCompiledItemAttribute")
8082
}
8183

8284
/**
@@ -176,7 +178,7 @@ private Expr getAViewLocationList(boolean isArea) {
176178
result
177179
.(PropertyRead)
178180
.getProperty()
179-
.hasQualifiedName("Microsoft.AspNetCore.Mvc.Razor", "RazorViewEngineOptions", name)
181+
.hasFullyQualifiedName("Microsoft.AspNetCore.Mvc.Razor", "RazorViewEngineOptions", name)
180182
|
181183
name = "ViewLocationFormats" and isArea = false
182184
or

0 commit comments

Comments
 (0)