Commit df5c62c
committed
Fix Go extractor incorrectly excluding cross-module dependencies
The Go extractor was incorrectly excluding valid packages from cross-module
workspace dependencies when their relative path from a wantedRoot contained
'..' (parent directory references).
Problem:
When using trace-command or specific package patterns (e.g., ./mainmodule/...),
only the input packages' ModDirs were added to wantedRoots. Cross-module
dependencies had their ModDir excluded, causing them to be skipped during
extraction when checked against unrelated sibling package directories.
Solution:
Add ModDir to wantedRoots for all packages during type extraction, including
cross-module workspace dependencies. This ensures dependency module roots are
valid extraction targets.
Testing:
- Added integration test at go/ql/integration-tests/package-exclusion-fix/
- Two-module workspace: configmodule and mainmodule
- Without fix: 2 files extracted (config.go missing)
- With fix: 4 files extracted (config.go present)
Run test: pytest go/ql/integration-tests/package-exclusion-fix/1 parent 5d2ddbf commit df5c62c
File tree
6 files changed
+57
-0
lines changed- go
- extractor
- ql/integration-tests/package-exclusion-fix
6 files changed
+57
-0
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
227 | 233 | | |
228 | 234 | | |
229 | 235 | | |
| |||
Lines changed: 5 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 14 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
0 commit comments