Skip to content

Commit d2b88ae

Browse files
committed
C#: Rename overloaded CheckFeeds method and fix comment
1 parent 7cea2ad commit d2b88ae

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/NugetPackageRestorer.cs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -701,7 +701,8 @@ private bool IsFeedReachable(string feed, int timeoutMilliSeconds, int tryCount,
701701
}
702702

703703
/// <summary>
704-
/// Checks that we can connect to all Nuget feeds that are explicitly configured in configuration files.
704+
/// Checks that we can connect to all Nuget feeds that are explicitly configured in configuration files
705+
/// as well as any private package registry feeds that are configured.
705706
/// </summary>
706707
/// <param name="explicitFeeds">Outputs the set of explicit feeds.</param>
707708
/// <returns>True if all feeds are reachable or false otherwise.</returns>
@@ -714,7 +715,7 @@ private bool CheckFeeds(out HashSet<string> explicitFeeds)
714715
// in addition to the ones that are configured in `nuget.config` files.
715716
this.dependabotProxy?.RegistryURLs.ForEach(url => feedsToCheck.Add(url));
716717

717-
var allFeedsReachable = this.CheckFeeds(feedsToCheck);
718+
var allFeedsReachable = this.CheckSpecifiedFeeds(feedsToCheck);
718719

719720
var inheritedFeeds = allFeeds.Except(explicitFeeds).ToHashSet();
720721
if (inheritedFeeds.Count > 0)
@@ -731,7 +732,7 @@ private bool CheckFeeds(out HashSet<string> explicitFeeds)
731732
/// </summary>
732733
/// <param name="feeds">The set of package feeds to check.</param>
733734
/// <returns>True if all feeds are reachable or false otherwise.</returns>
734-
private bool CheckFeeds(HashSet<string> feeds)
735+
private bool CheckSpecifiedFeeds(HashSet<string> feeds)
735736
{
736737
logger.LogInfo("Checking that Nuget feeds are reachable...");
737738

0 commit comments

Comments
 (0)