Java: remove explicit this that causes non-monotonic recursion

erik-krogh · erik-krogh · commit c870d87b833d · 2021-12-23T09:42:21.000+01:00
diff --git a/java/ql/lib/semmle/code/java/security/CommandArguments.qll b/java/ql/lib/semmle/code/java/security/CommandArguments.qll
@@ -153,7 +153,7 @@ private class CommandArgArrayImmutableFirst extends CommandArgumentArray {
   Expr getFirstElement() {
     result = this.getAWrite(0)
     or
-    not exists(this.getAWrite(0)) and
+    not exists(getAWrite(0)) and
     result = firstElementOf(this.getDefiningExpr())
   }
 

Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ private class CommandArgArrayImmutableFirst extends CommandArgumentArray {`
`153`	`153`	`Expr getFirstElement() {`
`154`	`154`	`result = this.getAWrite(0)`
`155`	`155`	`or`
`156`		`- not exists(this.getAWrite(0)) and`
	`156`	`+ not exists(getAWrite(0)) and`
`157`	`157`	`result = firstElementOf(this.getDefiningExpr())`
`158`	`158`	`}`
`159`	`159`