Skip to content

Commit c5b682c

Browse files
committed
C++: Respond to review comments.
1 parent 7b8301a commit c5b682c

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasAnalysis.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,8 +340,7 @@ private predicate resultEscapesNonReturn(Instruction instr) {
340340

341341
/** Holds if `operand` may (transitively) flow to an `AddressOperand` whose use is unmodeled. */
342342
private predicate consumedAsAddressOperand(Operand operand) {
343-
operand instanceof AddressOperand and
344-
exists(Instruction use | not use.isResultModeled())
343+
exists(Instruction use | use = operand.(AddressOperand).getUse() and not use.isResultModeled())
345344
or
346345
exists(Operand address |
347346
consumedAsAddressOperand(address) and

cpp/ql/lib/semmle/code/cpp/ir/implementation/unaliased_ssa/internal/AliasAnalysis.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -340,8 +340,7 @@ private predicate resultEscapesNonReturn(Instruction instr) {
340340

341341
/** Holds if `operand` may (transitively) flow to an `AddressOperand` whose use is unmodeled. */
342342
private predicate consumedAsAddressOperand(Operand operand) {
343-
operand instanceof AddressOperand and
344-
exists(Instruction use | not use.isResultModeled())
343+
exists(Instruction use | use = operand.(AddressOperand).getUse() and not use.isResultModeled())
345344
or
346345
exists(Operand address |
347346
consumedAsAddressOperand(address) and

0 commit comments

Comments
 (0)