Skip to content

Commit 8796800

Browse files
committed
fix all ql/unused-field warnings
1 parent d5fd0d6 commit 8796800

File tree

5 files changed

+4
-9
lines changed

5 files changed

+4
-9
lines changed

java/ql/lib/semmle/code/java/security/IntentUriPermissionManipulation.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,8 +96,6 @@ private class IntentFlagsOrDataChangedSanitizer extends IntentUriPermissionManip
9696
* ```
9797
*/
9898
private class IntentFlagsOrDataCheckedGuard extends IntentUriPermissionManipulationGuard {
99-
Expr condition;
100-
10199
IntentFlagsOrDataCheckedGuard() { intentFlagsOrDataChecked(this, _, _) }
102100

103101
override predicate checks(Expr e, boolean branch) { intentFlagsOrDataChecked(this, e, branch) }

java/ql/src/experimental/semmle/code/java/PathSanitizer.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,6 @@ private predicate isDisallowedWord(CompileTimeConstantExpr word) {
136136

137137
/** A complementary guard that protects against path traversal, by looking for the literal `..`. */
138138
class PathTraversalGuard extends Guard instanceof MethodAccess {
139-
Expr checked;
140-
141139
PathTraversalGuard() {
142140
super.getMethod().getDeclaringType() instanceof TypeString and
143141
super.getMethod().hasName(["contains", "indexOf"]) and

javascript/ql/lib/semmle/javascript/frameworks/ClientRequests.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,8 +330,6 @@ module ClientRequest {
330330
* A model of a URL request made using `require("needle")(...)`.
331331
*/
332332
class PromisedNeedleRequest extends ClientRequest::Range {
333-
DataFlow::Node url;
334-
335333
PromisedNeedleRequest() { this = DataFlow::moduleImport("needle").getACall() }
336334

337335
override DataFlow::Node getUrl() { result = this.getArgument(1) }

javascript/ql/lib/semmle/javascript/frameworks/CryptoLibraries.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -683,8 +683,6 @@ private module ExpressJwt {
683683
*/
684684
private module NodeRsa {
685685
private class CreateKey extends CryptographicKeyCreation, API::InvokeNode {
686-
CryptographicAlgorithm algorithm;
687-
688686
CreateKey() {
689687
this = API::moduleImport("node-rsa").getAnInstantiation()
690688
or

python/ql/src/experimental/semmle/python/frameworks/Flask.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,10 @@ module ExperimentalFlask {
7575
private class FlaskResponse extends DataFlow::CallCfgNode, HeaderDeclaration::Range {
7676
KeyValuePair item;
7777

78-
FlaskResponse() { this = Flask::Response::classRef().getACall() }
78+
FlaskResponse() {
79+
this = Flask::Response::classRef().getACall() and
80+
item = this.getArg(_).asExpr().(Dict).getAnItem()
81+
}
7982

8083
override DataFlow::Node getNameArg() { result.asExpr() = item.getKey() }
8184

0 commit comments

Comments
 (0)