wip4

Author: hvitved

rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll

@@ -2051,6 +2051,19 @@ private module AssocFunctionResolution {
     borrow = TSomeBorrowKind(true)
   }
 
+  private import codeql.rust.elements.internal.generated.Raw
+  private import codeql.rust.elements.internal.generated.Synth
+
+  private class RawImplOrTrait = @impl or @trait;
+
+  private predicate id(RawImplOrTrait x, RawImplOrTrait y) { x = y }
+
+  private predicate idOfRaw(RawImplOrTrait x, int y) = equivalenceRelation(id/2)(x, y)
+
+  private int idOfImplOrTraitItemNode(ImplOrTraitItemNode i) {
+    idOfRaw(Synth::convertAstNodeToRaw(i), result)
+  }
+
   bindingset[derefChain]
   private signature predicate fooSig(
     AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
@@ -2080,22 +2093,88 @@ private module AssocFunctionResolution {
       t = getNthLookupType(afc, strippedType, n)
     }
 
-    // forex using recursion
     pragma[nomagic]
-    private predicate hasNoCompatibleNonBlanketLikeTargetCheckToIndex(
+    private ImplOrTraitItemNode getNthNonBlanketLikeCandidate(
+      AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
+      TypePath strippedTypePath, Type strippedType, int n, Type t, int rnk
+    ) {
+      bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) and
+      // foo(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, _) and
+      // t = getNthLookupType(afc, strippedType, n) and
+      result =
+        rank[rnk + 1](ImplOrTraitItemNode i, int id |
+          nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t) and
+          id = idOfImplOrTraitItemNode(i)
+        |
+          i order by id
+        )
+    }
+
+    pragma[nomagic]
+    private int getLastNonBlanketLikeCandidateIndex(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
       TypePath strippedTypePath, Type strippedType, int n
     ) {
+      // max(int rnk |
+      //   exists(
+      //     getNthNonBlanketLikeCandidate(afc, selfPos, derefChain, borrow, strippedTypePath,
+      //       strippedType, n, t, rnk)
+      //   )
+      // )
       exists(Type t |
-        bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) and
-        forall(ImplOrTraitItemNode i |
-          nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t)
-        |
+        foo(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, _) and
+        t = getNthLookupType(afc, strippedType, n) and
+        result =
+          count(ImplOrTraitItemNode i |
+              nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t)
+            ) - 1
+      )
+    }
+
+    // forex using recursion
+    pragma[nomagic]
+    private predicate hasNoCompatibleNonBlanketLikeTargetCheckToIndexToIndex(
+      AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
+      TypePath strippedTypePath, Type strippedType, int n, int rnk
+    ) {
+      // afc = Debug::getRelevantLocatable() and
+      exists(Type t | bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) |
+        rnk = -1
+        or
+        hasNoCompatibleNonBlanketLikeTargetCheckToIndexToIndex(afc, selfPos, derefChain, borrow,
+          strippedTypePath, strippedType, n, rnk - 1) and
+        exists(ImplOrTraitItemNode i |
+          i =
+            getNthNonBlanketLikeCandidate(afc, selfPos, derefChain, borrow, strippedTypePath,
+              strippedType, n, t, rnk) and
           afc.hasIncompatibleTarget(i, selfPos, derefChain, borrow, t)
         )
       )
     }
 
+    // forex using recursion
+    pragma[nomagic]
+    private predicate hasNoCompatibleNonBlanketLikeTargetCheckToIndex(
+      AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow,
+      TypePath strippedTypePath, Type strippedType, int n
+    ) {
+      exists(int last |
+        last =
+          getLastNonBlanketLikeCandidateIndex(afc, selfPos, derefChain, borrow, strippedTypePath,
+            strippedType, n) and
+        hasNoCompatibleNonBlanketLikeTargetCheckToIndexToIndex(afc, selfPos, derefChain, borrow,
+          strippedTypePath, strippedType, n, last)
+      )
+      // exists(Type t |
+      //   bar(afc, selfPos, derefChain, borrow, strippedTypePath, strippedType, n, t) and
+      //   forall(ImplOrTraitItemNode i |
+      //     nonBlanketLikeCandidate(afc, selfPos, i, _, strippedTypePath, t)
+      //   |
+      //     afc.hasIncompatibleTarget(i, selfPos, derefChain, borrow, t)
+      //   )
+      // )
+    }
+
     pragma[nomagic]
     predicate hasNoCompatibleNonBlanketLikeTargetCheck(
       AssocFunctionCall afc, FunctionPosition selfPos, DerefChain derefChain, BorrowKind borrow
@@ -4005,8 +4084,8 @@ private module Debug {
   Locatable getRelevantLocatable() {
     exists(string filepath, int startline, int startcolumn, int endline, int endcolumn |
       result.getLocation().hasLocationInfo(filepath, startline, startcolumn, endline, endcolumn) and
-      filepath.matches("%/main.rs") and
-      startline = 1986
+      filepath.matches("%/overloading.rs") and
+      startline = [398 .. 399]
     )
   }