Merge pull request #10261 from MathiasVP/fix-join-in-sign-analysis

MathiasVP · web-flow · commit 2223bc3d1f05 · 2022-09-01T16:49:05.000+01:00
C++: Fix join in sign analysis
diff --git a/cpp/ql/lib/experimental/semmle/code/cpp/semantic/analysis/SignAnalysisCommon.qll b/cpp/ql/lib/experimental/semmle/code/cpp/semantic/analysis/SignAnalysisCommon.qll
@@ -204,6 +204,7 @@ private class BinarySignExpr extends FlowSignExpr {
   }
 }
 
+pragma[nomagic]
 private predicate binaryExprOperands(SemBinaryExpr binary, SemExpr left, SemExpr right) {
   binary.getLeftOperand() = left and binary.getRightOperand() = right
 }

Original file line number	Diff line number	Diff line change
`@@ -204,6 +204,7 @@ private class BinarySignExpr extends FlowSignExpr {`
`204`	`204`	`}`
`205`	`205`	`}`
`206`	`206`
	`207`	`+pragma[nomagic]`
`207`	`208`	`private predicate binaryExprOperands(SemBinaryExpr binary, SemExpr left, SemExpr right) {`
`208`	`209`	`binary.getLeftOperand() = left and binary.getRightOperand() = right`
`209`	`210`	`}`