Java: use two negations

Jami Cogswell · Jami Cogswell · commit 15b576bdb537 · 2025-01-08T18:24:38.000-05:00
diff --git a/java/ql/lib/semmle/code/java/security/CsrfUnprotectedRequestTypeQuery.qll b/java/ql/lib/semmle/code/java/security/CsrfUnprotectedRequestTypeQuery.qll
@@ -42,10 +42,8 @@ private class SpringCsrfUnprotectedMethod extends CsrfUnprotectedMethod instance
 private class StaplerCsrfUnprotectedMethod extends CsrfUnprotectedMethod instanceof StaplerWebMethod
 {
   StaplerCsrfUnprotectedMethod() {
-    not (
-      this.hasAnnotation("org.kohsuke.stapler.interceptor", "RequirePOST") or
-      this.hasAnnotation("org.kohsuke.stapler.verb", "POST")
-    )
+    not this.hasAnnotation("org.kohsuke.stapler.interceptor", "RequirePOST") and
+    not this.hasAnnotation("org.kohsuke.stapler.verb", "POST")
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -42,10 +42,8 @@ private class SpringCsrfUnprotectedMethod extends CsrfUnprotectedMethod instance`
`42`	`42`	`private class StaplerCsrfUnprotectedMethod extends CsrfUnprotectedMethod instanceof StaplerWebMethod`
`43`	`43`	`{`
`44`	`44`	`StaplerCsrfUnprotectedMethod() {`
`45`		`- not (`
`46`		`- this.hasAnnotation("org.kohsuke.stapler.interceptor", "RequirePOST") or`
`47`		`- this.hasAnnotation("org.kohsuke.stapler.verb", "POST")`
`48`		`- )`
	`45`	`+ not this.hasAnnotation("org.kohsuke.stapler.interceptor", "RequirePOST") and`
	`46`	`+ not this.hasAnnotation("org.kohsuke.stapler.verb", "POST")`
`49`	`47`	`}`
`50`	`48`	`}`
`51`	`49`