Merge pull request #11306 from tamasvajk/kotlin-equals-missing

Kotlin: Exclude .kt files from missing `instanceof` in `equals` query
github · Nov 17, 2022 · 1118830 · 1118830
2 parents 45d4318 + fc614ad
commit 1118830
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql b/java/ql/src/Likely Bugs/Comparison/MissingInstanceofInEquals.ql
@@ -64,6 +64,7 @@ class UnimplementedEquals extends EqualsMethod {
 
 from EqualsMethod m
 where
+  m.getFile().isJavaSourceFile() and
   exists(m.getBody()) and
   exists(Parameter p | p = m.getAParameter() |
     // The parameter has no type test

diff --git a/java/ql/test/kotlin/query-tests/MissingInstanceofInEquals/Test.kt b/java/ql/test/kotlin/query-tests/MissingInstanceofInEquals/Test.kt
@@ -17,3 +17,9 @@ data class G(val x: Int) {
         return other != null && other.javaClass == this.javaClass
     }
 }
+
+data class H(val x: Int) {
+    override fun equals(other: Any?): Boolean {
+        return other != null
+    }
+}