Skip to content

Commit 0648392

Browse files
committed
JS: removed unnecessary findlast module import
1 parent 72a69cf commit 0648392

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed
Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
---
22
category: minorAnalysis
33
---
4-
* Added pre call graph step for `Array.prototype.findLast`
4+
* Added taint-steps for `Array.prototype.findLast`
5+
* Added taint-steps for `Array.prototype.findLastIndex`

javascript/ql/test/library-tests/Arrays/arrays.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,4 +109,12 @@
109109
sink(arr8_spread.pop()); // NOT OK
110110

111111
sink(arr.findLast(someCallback)); // NOT OK
112+
113+
114+
const myList = [source()];
115+
const element = myList.findLast((item) => sink(item)); // NOT OK - caught by both taint and dataflow tracking.
116+
sink(element); // NOT OK
117+
118+
const mySecondList = source();
119+
const elementSecond = mySecondList.findLast((item) => sink(item)); // NOT OK - only caught by taint-tracking.
112120
});

0 commit comments

Comments
 (0)