Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog #507

Merged
merged 3 commits into from
May 19, 2021
Merged

Add a changelog #507

merged 3 commits into from
May 19, 2021

Conversation

aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented May 18, 2021

Adds an empty changelog file and a reminder to update it when opening
pull requests.

Also, adds a 1.0.0 version number in the package.json, which is what
we will use for version numbering.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.

.github/pull_request_template.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Adds an empty changelog file and a reminder to update it when opening
pull requests.

Also, adds a 1.0.0 version number in the package.json, which is what
we _could_ use for version numbering.
@aeisenberg aeisenberg force-pushed the aeisenberg/changelog branch from 03ff062 to 8566f9b Compare May 19, 2021 22:19
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo, otherwise good to go. Maybe the first changelog entry should be adding the changelog!

CHANGELOG.md Outdated Show resolved Hide resolved
aeisenberg and others added 2 commits May 19, 2021 15:28
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants