Deprecate add-snippets input.
#2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeisenberg
previously approved these changes
Aug 21, 2024
Co-authored-by: Andrew Eisenberg <aeisenberg@github.com>
aeisenberg
previously approved these changes
Aug 21, 2024
henrymercer
reviewed
Aug 21, 2024
CHANGELOG.md
Outdated
| @@ -24,6 +24,7 @@ No user facing changes. | |||
|
|
|||
| - _Deprecation:_ Swift analysis on Ubuntu runner images is no longer supported. Please migrate to a macOS runner if this affects you. [#2403](https://github.com/github/codeql-action/pull/2403) | |||
| - Bump the minimum CodeQL bundle version to 2.13.5. [#2408](https://github.com/github/codeql-action/pull/2408) | |||
| - _Deprecation:_ The `add-snippets` input on the `analyze` Action is deprecated and will be removed in the first release in August 2025. [#2436](https://github.com/github/codeql-action/pull/2436) | |||
There was a problem hiding this comment.
Did you intentionally add this to 3.26.0?
There was a problem hiding this comment.
I added it to unreleased, must have gone wrong when I accepted a review suggestion 🤔. Let me move it back to unreleased.
henrymercer
approved these changes
Aug 21, 2024
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge / deployment checklist