Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swift+linux deprecation #2403

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Add swift+linux deprecation #2403

merged 3 commits into from
Aug 2, 2024

Conversation

aeisenberg
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@aeisenberg aeisenberg requested a review from a team as a code owner August 1, 2024 22:49
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated
@@ -6,15 +6,15 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the

## [UNRELEASED]

No user facing changes.
- _Deprecation:_ Analyzing databases on Swift support on Ubuntu runner images is no longer supported. Please migrate to a MacOS runner if this affects you.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get the Action to produce a deprecation warning if it detects the combination of Swift and Linux?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. @angelapwen will work on that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the warning in #2399.

Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
adityasharad
adityasharad previously approved these changes Aug 1, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
@aeisenberg aeisenberg merged commit 8b7d739 into main Aug 2, 2024
305 checks passed
@aeisenberg aeisenberg deleted the aeisenberg/swift-linux branch August 2, 2024 14:11
@github-actions github-actions bot mentioned this pull request Aug 6, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants