Add deprecation warning for merging SARIF files with non-unique categories #2265
Conversation
src/upload-lib.ts
Outdated
| ) | ||
| ) { | ||
| logger.warning( | ||
| `Uploading multiple CodeQL runs with the same category is deprecated ${deprecationWarningMessage}. Please update your CodeQL CLI version or update your workflow to set a distinct category for each CodeQL run. For more information, see https://github.blog/changelog/2024-05-06-code-scanning-will-stop-combining-runs-deprecation-notice`, |
There was a problem hiding this comment.
Is this the same message as above? If so, probably best to extract to a variable so we don't accidentally change one but not the other.
There was a problem hiding this comment.
No, the message is not exactly the same. I'll extract the last part ("For more information, see ..."), but the other parts of the message are different. The first message is for third-party tools, while the second message is more specific to CodeQL-only uploads.
|
Thanks for the reviews!
I've added tests for the (renamed) |
I think we can actually merge this before the changelog post is out since the deprecation message is behind a feature flag. Does that make sense, or do you think it would be better to wait? |
|
Ah perfect, just make sure the changelog's out before you start rolling out the feature flag then! Thanks! |
This adds a deprecation warning for merging SARIF files with non-unique categories. This is behind a feature flag.
These are the criteria for showing the deprecation warning:
Merge / deployment checklist