-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update release process to support multiple version #2014
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! My main comment is around what happens the first time we backport a new major version of the Action.
Co-authored-by: Henry Mercer <henry.mercer@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thanks for addressing my comments!
This PR udpates the release process in order to handle maintaining multiple versions. To a large extent this reintroduces the logic removed in...
...but adapted in order to avoid hardcoding version numbers. The process should also support maintaining two or more older version of the action, should that ever be required.
The process to release a new version will now be to first bump the major version number and merge that PR to
main
. Then run theupdate-release-branch.yml
workflow, which will...releases/vNew
branchmain
update-release-branch.yml
will be triggered again, this time opening mergeback PRs againstfrom releases/vLatest
to all previous supported release branchesupdate-release-branch.yml
workflow will also run, updating the tags forvLatest
as required and if the release branch is the latest one then also opening a backport PR tomain
Note that both these workflows will also be triggered when mergeback PRs are merged against older release branches, but in this case
update-release-branch.yml
will take no action andupdate-release-branch.yml
will run only the operations to ensure tags for the relevant version are up to date.Retiring older versions is now a matter of updating
OLDEST_SUPPORTED_MAJOR_VERSION
inrelease-branches.py
, see the new section inCONTRIBUTING.md
for details.NB The changes in this PR have been tested in a private fork of the repository.
Merge / deployment checklist