Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for CodeQL v2.11.5 and earlier #2009

Merged
merged 8 commits into from
Jan 4, 2024

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Nov 27, 2023

Remove support for CodeQL v2.11.5 and earlier, as announced in CodeQL Action v2.22.7.

I think it makes sense to remove support for CLI config parsing in a separate PR to simplify review and due to this being a higher risk code change.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer
Copy link
Contributor Author

We'll need to update the set of required checks before merging this, since this PR stops testing CodeQL v2.10.5.

angelapwen
angelapwen previously approved these changes Nov 27, 2023
CHANGELOG.md Outdated
@@ -4,7 +4,7 @@ See the [releases page](https://github.com/github/codeql-action/releases) for th

## [UNRELEASED]

No user facing changes.
- The CodeQL Action now requires CodeQL version 2.11.6 or later. For more information, see the corresponding changelog entry for CodeQL Action version 2.22.7. [#2009](https://github.com/github/codeql-action/pull/2009)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

angelapwen
angelapwen previously approved these changes Nov 27, 2023
auto-merge was automatically disabled November 27, 2023 18:17

Pull Request is not mergeable

@henrymercer henrymercer disabled auto-merge November 27, 2023 18:20
@henrymercer henrymercer disabled auto-merge November 27, 2023 18:28
@henrymercer
Copy link
Contributor Author

The deprecation date was changed to 2023-12-20, so we need to hold off merging this until then.

@henrymercer
Copy link
Contributor Author

New deprecation date is 2024-01-04.

@henrymercer henrymercer merged commit 7963a60 into main Jan 4, 2024
336 checks passed
@henrymercer henrymercer deleted the henrymercer/drop-codeql-v2.11.5 branch January 4, 2024 13:27
@github-actions github-actions bot mentioned this pull request Jan 8, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants