-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++: introduce automatic installation of dependencies in the autobuilder #1889
Conversation
242362a
to
1dc6288
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it will do the right thing, though I have a couple of questions about whether we can simplify the experience by reducing the amount of configuration options. Let me know what you think!
This introduces the possibility to automatically install dependencies when running the C++ autobuilder on an Ubuntu runner, that will be available with upcoming version 2.15.0. An experimental `cpp-autoinstall-dependencies` input is added to the `autobuild` action. When not set, the default is driven by a feature flag.
6de7ce6
to
765807b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions around logging, but LGTM otherwise!
Co-authored-by: Henry Mercer <henry.mercer@me.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent!
This introduces the possibility to automatically install dependencies when running the C++ autobuilder on an Ubuntu runner, that will be available with upcoming version 2.15.0. This behaviour can be explicitly requested by setting
CODEQL_EXTRACTOR_CPP_AUTOINSTALL_DEPENDENCIES
in theautobuild
actionenv
, or is otherwise driven by thecode_scanning_cpp_dependency_installation
feature flag.Merge / deployment checklist