Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lombok: Don't set env var if it's already set #1844

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Lombok: Don't set env var if it's already set #1844

merged 4 commits into from
Aug 18, 2023

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Aug 18, 2023

If the user has manually configured it, then we let their setting stand.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@igfoo igfoo requested a review from a team as a code owner August 18, 2023 11:18
@igfoo igfoo force-pushed the igfoo/lombok_no_overwrite branch from 3d8058b to b24d125 Compare August 18, 2023 11:25
igfoo added 3 commits August 18, 2023 12:31
@igfoo
Lombok: Don't set env var if it's already set
d5b5e18 
If the user has manually configured it, then we let their setting stand.
@igfoo
npm run build
b557ee7
@igfoo
Add a changenote for the Lombok change
c34b59d
@igfoo igfoo force-pushed the igfoo/lombok_no_overwrite branch from b24d125 to c34b59d Compare August 18, 2023 11:31
adityasharad
adityasharad reviewed Aug 18, 2023
View reviewed changes
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One changenote suggestion.

CHANGELOG.md Outdated Show resolved Hide resolved
@igfoo @adityasharad
Tweak CHANGELOG.md
ddf2bd2 
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
@igfoo igfoo merged commit e426271 into main Aug 18, 2023
@igfoo igfoo deleted the igfoo/lombok_no_overwrite branch August 18, 2023 18:57
@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityasharad adityasharad adityasharad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igfoo @adityasharad