Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MismatchedBranches check from code scanning workflow validation #1675

Merged
merged 7 commits into from
May 11, 2023
Merged

Remove MismatchedBranches check from code scanning workflow validation #1675

merged 7 commits into from
May 11, 2023

Conversation

shaikhul
Copy link
Contributor

@shaikhul shaikhul commented May 9, 2023 •
edited
Loading

Remove MismatchedBranches check from code scanning workflow validation as these two have misleading wording.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@shaikhul shaikhul requested a review from a team as a code owner May 9, 2023 14:44
@shaikhul shaikhul requested a review from henrymercer May 9, 2023 14:55
henrymercer
henrymercer previously approved these changes May 10, 2023
View reviewed changes
src/workflow.test.ts Show resolved Hide resolved
@henrymercer
Copy link
Contributor

My understanding is that the main change of this PR is to remove the checks for push triggers in code scanning workflows, since with the simplified diff approach this is no longer required. If that's right, could we update the PR title / description accordingly? We may also want to add a brief changelog note in CHANGELOG.md. This will make it easier to find this PR in the future.

@shaikhul shaikhul changed the title Remove consts MismatchedBranches and MissingPushHook Remove MismatchedBranches and MissingPushHook checks from code scanning workflow validation May 10, 2023
@shaikhul shaikhul requested a review from henrymercer May 10, 2023 15:03
@shaikhul shaikhul changed the title Remove MismatchedBranches and MissingPushHook checks from code scanning workflow validation Remove MismatchedBranches check from code scanning workflow validation May 10, 2023
henrymercer
henrymercer previously approved these changes May 11, 2023
View reviewed changes
src/workflow.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@shaikhul @henrymercer
Apply suggestions from code review
e5fdcd4 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@shaikhul shaikhul requested a review from henrymercer May 11, 2023 14:08
@henrymercer
Copy link
Contributor

@shaikhul Would you mind recompiling the Action and pushing again? 🙏 Unfortunately for now we need to check in the compiled code.

@shaikhul
Copy link
Contributor Author

@henrymercer done 903cb27

henrymercer
henrymercer previously approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! One fix to the changelog format I didn't notice before, otherwise this is good to go!

CHANGELOG.md Outdated Show resolved Hide resolved
@shaikhul @henrymercer
Update CHANGELOG.md
a0755a7 
Co-authored-by: Henry Mercer <henry.mercer@me.com>
@henrymercer henrymercer enabled auto-merge May 11, 2023 14:23
@henrymercer henrymercer merged commit 130884e into github:main May 11, 2023
@github-actions github-actions bot mentioned this pull request May 24, 2023
Merged
6 tasks
@atc0005 atc0005 mentioned this pull request May 25, 2023
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaikhul @henrymercer