Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundle to 2.12.0 #1466

Merged
merged 8 commits into from
Jan 10, 2023
Merged

Update bundle to 2.12.0 #1466

merged 8 commits into from
Jan 10, 2023

Conversation

dbartol
Copy link
Contributor

@dbartol dbartol commented Jan 6, 2023

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@dbartol dbartol requested a review from a team as a code owner January 6, 2023 16:01
@dbartol dbartol marked this pull request as draft January 6, 2023 16:01
@angelapwen
Copy link
Contributor

Hi — I've just merged #1463 which creates some merge conflicts here. We'll be updating the release documentation shortly to include this, but wanted to write an FYI that we've added a few fields to the file that include the actual version number of the current release, as well as the bundle name + version number of the previous release 😄 let me know if any questions!

@dbartol
Copy link
Contributor Author

dbartol commented Jan 6, 2023

@angelapwen Thanks for the heads up!

henrymercer
henrymercer previously approved these changes Jan 6, 2023
@dbartol dbartol marked this pull request as ready for review January 10, 2023 14:30
@dbartol dbartol enabled auto-merge January 10, 2023 14:30
@@ -2,7 +2,7 @@

## [UNRELEASED]

No user facing changes.
- Update default CodeQL bundle version to 2.12.0. [#1466](https://github.com/github/codeql-action/pull/1466)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something minor and doesn't need to happen for this release, but perhaps we should start linking to the release notes for the CLI version we are upgrading to.

aeisenberg
aeisenberg previously approved these changes Jan 10, 2023
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear...this integration test will continue to fail until it starts using a version of the CLI that supports kotlin 1.8.0?

I think that is fine, but if this gets annoying, we should disable this test in main and create an issue to remind ourselves to re-enable it.

henrymercer and others added 3 commits January 10, 2023 17:31
Kotlin analysis is incompatible with Kotlin 1.8.0, which is now rolling
out to the Actions runner images.

While we work on a more permanent fix to our PR checks, this will
prevent us losing other
test coverage.
…kotlin-in-pr-checks

Temporarily disable Kotlin analysis in PR checks
@henrymercer henrymercer dismissed stale reviews from aeisenberg and themself via f12f76f January 10, 2023 19:49
@dbartol dbartol merged commit bdc7c5d into main Jan 10, 2023
@dbartol dbartol deleted the dbartol/bundle-20230105 branch January 10, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants