Skip to content

Commit dabf6fc

Browse files
committed
Adjust step names to be clearer
1 parent 14c5d77 commit dabf6fc

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

.github/workflows/__upload-sarif.yml

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/upload-sarif.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@ steps:
2929
sarif_file: ${{ runner.temp }}/results
3030
category: |
3131
${{ github.workflow }}:upload-sarif/analysis-kinds:${{ matrix.analysis-kinds }}/os:${{ matrix.os }}/version:${{ matrix.version }}/test:all-files/
32-
- name: "Check output from `upload-sarif` step for `code-scanning`"
32+
- name: "Fail for missing output from `upload-sarif` step for `code-scanning`"
3333
if: "contains(matrix.analysis-kinds, 'code-scanning') && !(fromJSON(steps.upload-sarif.outputs.sarif-ids).code-scanning)"
3434
run: exit 1
35-
- name: "Check output from `upload-sarif` step for `code-quality`"
35+
- name: "Fail for missing output from `upload-sarif` step for `code-quality`"
3636
if: "contains(matrix.analysis-kinds, 'code-quality') && !(fromJSON(steps.upload-sarif.outputs.sarif-ids).code-quality)"
3737
run: exit 1
3838

@@ -46,10 +46,10 @@ steps:
4646
sarif_file: ${{ runner.temp }}/results/javascript.sarif
4747
category: |
4848
${{ github.workflow }}:upload-sarif/analysis-kinds:${{ matrix.analysis-kinds }}/os:${{ matrix.os }}/version:${{ matrix.version }}/test:single-code-scanning/
49-
- name: "Check output from `upload-single-sarif-code-scanning` step"
49+
- name: "Fail for missing output from `upload-single-sarif-code-scanning` step"
5050
if: "contains(matrix.analysis-kinds, 'code-scanning') && !(fromJSON(steps.upload-single-sarif-code-scanning.outputs.sarif-ids).code-scanning)"
5151
run: exit 1
52-
- name: Upload single SARIF file for Code Scanning
52+
- name: Upload single SARIF file for Code Quality
5353
uses: ./../action/upload-sarif
5454
id: upload-single-sarif-code-quality
5555
if: "contains(matrix.analysis-kinds, 'code-quality')"
@@ -59,7 +59,7 @@ steps:
5959
sarif_file: ${{ runner.temp }}/results/javascript.quality.sarif
6060
category: |
6161
${{ github.workflow }}:upload-sarif/analysis-kinds:${{ matrix.analysis-kinds }}/os:${{ matrix.os }}/version:${{ matrix.version }}/test:single-code-quality/
62-
- name: "Check output from `upload-single-sarif-code-quality` step"
62+
- name: "Fail for missing output from `upload-single-sarif-code-quality` step"
6363
if: "contains(matrix.analysis-kinds, 'code-quality') && !(fromJSON(steps.upload-single-sarif-code-quality.outputs.sarif-ids).code-quality)"
6464
run: exit 1
6565

@@ -76,6 +76,6 @@ steps:
7676
sarif_file: ${{ runner.temp }}/results/javascript.sarif.json
7777
category: |
7878
${{ github.workflow }}:upload-sarif/analysis-kinds:${{ matrix.analysis-kinds }}/os:${{ matrix.os }}/version:${{ matrix.version }}/test:non-sarif/
79-
- name: "Check output from `upload-single-non-sarif` step"
79+
- name: "Fail for missing output from `upload-single-non-sarif` step"
8080
if: "contains(matrix.analysis-kinds, 'code-scanning') && !(fromJSON(steps.upload-single-non-sarif.outputs.sarif-ids).code-scanning)"
8181
run: exit 1

0 commit comments

Comments
 (0)