Skip to content

Commit

Permalink
Merge pull request #2062 from github/henrymercer/remove-action-config…
Browse files Browse the repository at this point in the history
…-parsing

Remove config parsing logic that is now implemented in the CLI
  • Loading branch information
henrymercer authored Jan 5, 2024
2 parents 08ae9bf + a533ec6 commit 8516954
Show file tree
Hide file tree
Showing 56 changed files with 472 additions and 6,046 deletions.
1 change: 0 additions & 1 deletion .github/workflows/__config-export.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 0 additions & 13 deletions .github/workflows/codescanning-config-cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
name: Code-Scanning config CLI tests
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
CODEQL_PASS_CONFIG_TO_CLI: true

on:
push:
Expand Down Expand Up @@ -204,15 +203,3 @@ jobs:
packs: + codeql/javascript-queries
config-file-test: .github/codeql/other-config-properties.yml
tools: ${{ steps.prepare-test.outputs.tools-url }}

- name: Config not generated when env var is not set
if: success() || failure()
env:
CODEQL_PASS_CONFIG_TO_CLI: false
uses: ./../action/.github/actions/check-codescanning-config
with:
expected-config-file-contents: ""
languages: javascript
packs: + codeql/javascript-queries
config-file-test: .github/codeql/other-config-properties.yml
tools: ${{ steps.prepare-test.outputs.tools-url }}
84 changes: 0 additions & 84 deletions lib/analysis-paths.js

This file was deleted.

1 change: 0 additions & 1 deletion lib/analysis-paths.js.map

This file was deleted.

124 changes: 0 additions & 124 deletions lib/analysis-paths.test.js

This file was deleted.

1 change: 0 additions & 1 deletion lib/analysis-paths.test.js.map

This file was deleted.

Loading

0 comments on commit 8516954

Please sign in to comment.