Fix auto-detection of extractors that aren't languages

Author: henrymercer

lib/config-utils.js

@@ -63,6 +63,7 @@ function createTestInitConfigInputs(
         async betterResolveLanguages() {
           return {
             extractors: {
+              html: [{ extractor_root: "" }],
               javascript: [{ extractor_root: "" }],
             },
           };
@@ -1125,6 +1126,20 @@ const mockRepositoryNwo = parseRepositoryNwo("owner/repo");
     expectedApiCall: false,
     expectedError: configUtils.getUnknownLanguagesError(["a", "b"]),
   },
+  {
+    name: "extractors that aren't languages aren't included (specified)",
+    languagesInput: "html",
+    languagesInRepository: [],
+    expectedApiCall: false,
+    expectedError: configUtils.getUnknownLanguagesError(["html"]),
+  },
+  {
+    name: "extractors that aren't languages aren't included (autodetected)",
+    languagesInput: "",
+    languagesInRepository: ["html", "javascript"],
+    expectedApiCall: true,
+    expectedLanguages: ["javascript"],
+  },
 ].forEach((args) => {
   test(`getLanguages: ${args.name}`, async (t) => {
     const mockRequest = mockLanguagesInRepo(args.languagesInRepository);

lib/config-utils.js.map

@@ -310,7 +310,13 @@ export async function getSupportedLanguageMap(
   const supportedLanguages: Record<string, string> = {};
   // Populate canonical language names
   for (const extractor of Object.keys(resolveResult.extractors)) {
-    supportedLanguages[extractor] = extractor;
+    // Require the language to be a known language.
+    // This is a temporary workaround since we have extractors that are not
+    // supported languages, such as `csv`, `html`, `properties`, `xml`, and
+    // `yaml`. We should replace this with a more robust solution in the future.
+    if (KnownLanguage[extractor] !== undefined) {
+      supportedLanguages[extractor] = extractor;
+    }
   }
   // Populate language aliases
   if (resolveResult.aliases) {

lib/config-utils.test.js

@@ -8,8 +8,9 @@ export type Language = string;
  * languages do not need to be added here.
  */
 export enum KnownLanguage {
-  csharp = "csharp",
+  actions = "actions",
   cpp = "cpp",
+  csharp = "csharp",
   go = "go",
   java = "java",
   javascript = "javascript",