Skip to content

Commit 329c022

Browse files
committed
Just check the number of locations
Only tests the property we are looking for and avoids problems with different cross-platform behavior.
1 parent c8935d5 commit 329c022

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

.github/workflows/__diagnostics-export.yml

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/diagnostics-export.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,6 @@ steps:
5151
if (n.locations.length !== 1) {
5252
core.setFailed(`Expected the status page diagnostic to have exactly 1 location, but found ${n.locations.length}.`);
5353
}
54-
const actualUri = n.locations[0].physicalLocation?.artifactLocation?.uri
55-
if (actualUri !== '/path/to/file') {
56-
core.setFailed(`Expected the status page diagnostic to have a location with the URI '/path/to/file', but found '${actualUri}'.`);
57-
}
5854
}
5955
6056
const sarif = JSON.parse(fs.readFileSync(process.env['SARIF_PATH'], 'utf8'));

0 commit comments

Comments
 (0)