Re-order env to be first argument for consistency

Author: mario-campos

lib/entry-points.js

@@ -59,14 +59,14 @@ function getCommandCacheFilePath(env: Env): string {
 
 /**
  * Caches the CodeQL CLI version both in-memory and on disk.
+ * @param env The environment variables to use.
  * @param cmd The path to the CodeQL CLI.
  * @param version The version information to cache.
- * @param env The environment variables to use.
  */
 export function cacheCodeQlVersion(
+  env: Env,
   cmd: string,
   version: VersionInfo,
-  env: Env,
 ): void {
   if (cachedCodeQlVersion !== undefined) {
     throw new Error("cacheCodeQlVersion() should be called only once");

src/cli/output-cache.ts

@@ -499,7 +499,7 @@ async function getCodeQLForCmd(
             noStreamStdout: true,
           },
         );
-        outputCache.cacheCodeQlVersion(cmd, result, getEnv());
+        outputCache.cacheCodeQlVersion(getEnv(), cmd, result);
       }
       return result;
     },