-
Notifications
You must be signed in to change notification settings - Fork 41
Conversation
seems golang.org/x/sys/windows drop support of 1.8
|
/cc @github/prodsec-reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! This is a fairly large change and wanted to share some thoughts before it gets reviewed in detail.
replace cgo with sys call. gcc is not widely used on windows
This results in a fairly substantial change. Though I can understand that GCC and such tooling are not widely distributed on Windows, they are available. I also personally tend to find the syscall code more difficult to read. Is there a benefit to the syscall move aside from not having a dependency on GCC?
force use cng. cng is recommend after vista
I would have to go back and see why CAPI support was added initially, but if I had a hunch it is to be compatible with some PIV card handlers that do not support CNG. That might be less of a concern now, but given the choice of removing support for something and continuing to support it, my preference would be to continue to support it. How difficult would it be to continue to support CAPI?
CGO I also trying to move all syscall (or dll call) to window pkg in order to make code more readable https://go-review.googlesource.com/c/sys/+/273907 honestly, no benefits other than removing the dependency on gcc. but still, having a gcc made this pkg not easy to use on windows. CAPI To support CAPI, just a convert those window API into go syscall pattern. not a big deal.
|
GO 1.13 is EOL you want want to remove those unsupported versions |
This project is now part of |
OpenStoreWindows
which takesstore name
andstore location
.