Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing information in json files compared to the advisory page #1580

Open
Hritik14 opened this issue Jan 7, 2023 · 5 comments
Open

Missing information in json files compared to the advisory page #1580

Hritik14 opened this issue Jan 7, 2023 · 5 comments

Comments

@Hritik14
Copy link

Hritik14 commented Jan 7, 2023

For example:
The https://github.com/github/advisory-database/blob/5b6aa08e4edaca41f91dbe18cf8c6fd65cefe528/advisories/github-reviewed/2023/01/GHSA-c653-6hhg-9x92/GHSA-c653-6hhg-9x92.json JSON does not contain the "credit" information from GHSA-c653-6hhg-9x92

Reference: aboutcode-org/vulnerablecode#297 (comment) by @pombredanne

@KateCatlin
Copy link
Collaborator

Hey @Hritik14 thanks for reaching out with this! We're currently working on adding credits (and credit types) to the JSON files.

Can you tell me about how this came to your attention? Was there something you wanted to do with credit information from the JSON files?

@Hritik14
Copy link
Author

Hritik14 commented Jan 14, 2023

Hello @KateCatlin!
We're developing an open vulnerabilities database at https://github.com/nexB/vulnerablecode and are interested in all advisory data that we may find. In my understanding, the web advisory page gets generated using the given json files but this doesn't seem to be the case as json files contain less (and not more) information than available on the web page.

I do not think it is ideal to scrape the webpage for anything, instead if you could provide a structured source of all data present on the webpage, it would be great!

@KateCatlin
Copy link
Collaborator

Makes sense, thanks @Hritik14. I'll keep this thread updated when we launch!

@KateCatlin
Copy link
Collaborator

Hey @Hritik14 update on this–

We did indeed ship our work to support different credit types on advisories. But due to technical reasons, displaying credit information in the JSON files would have made this epic 2-3x as much work, so we cut that part for now.

I understand this is likely frustrating and I'm using this feedback to more highly prioritize getting credit information into JSON files in a future quarter.

Leaving this issue open for others to chime in for support if desired!

@brycx
Copy link

brycx commented Apr 14, 2023

I'm missing support for this as well. I have some advisories that I want credited, which were imported from NVD mostly, but am unable to correctly update this information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants