Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Commit 5fdff92

Browse files
committed
Don't display [None] twice.
The empty list item was getting added twice: once by the XAML and once in PullRequestListViewModel. This removes the XAML empty list item code as I assume it's supposed to be set in the VM. Fixes #390.
1 parent 02bf074 commit 5fdff92

File tree

1 file changed

+2
-18
lines changed

1 file changed

+2
-18
lines changed

src/GitHub.VisualStudio/UI/Views/PullRequestListView.xaml

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -214,17 +214,9 @@
214214

215215
<ListBox x:Name="assignees"
216216
DockPanel.Dock="Top"
217+
ItemsSource="{Binding Assignees}"
217218
SelectedItem="{Binding SelectedAssignee}"
218219
Style="{DynamicResource GitHubPopupThing}">
219-
<ListBox.ItemsSource>
220-
<MultiBinding Converter="{ui:StickieListItemConverter}">
221-
<Binding Path="EmptyUser" />
222-
<Binding Path="Assignees" />
223-
</MultiBinding>
224-
</ListBox.ItemsSource>
225-
<i:Interaction.Behaviors>
226-
<ui:AddEmptyItemToList />
227-
</i:Interaction.Behaviors>
228220
<i:Interaction.Triggers>
229221
<i:EventTrigger EventName="SelectionChanged">
230222
<ui:ClosePopupAction TargetName="assigneePopup" />
@@ -263,17 +255,9 @@
263255

264256
<ListBox x:Name="authors"
265257
DockPanel.Dock="Top"
258+
ItemsSource="{Binding Authors}"
266259
SelectedItem="{Binding SelectedAuthor}"
267260
Style="{DynamicResource GitHubPopupThing}">
268-
<ListBox.ItemsSource>
269-
<MultiBinding Converter="{ui:StickieListItemConverter}">
270-
<Binding Path="EmptyUser" />
271-
<Binding Path="Authors" />
272-
</MultiBinding>
273-
</ListBox.ItemsSource>
274-
<i:Interaction.Behaviors>
275-
<ui:AddEmptyItemToList />
276-
</i:Interaction.Behaviors>
277261
<i:Interaction.Triggers>
278262
<i:EventTrigger EventName="SelectionChanged">
279263
<ui:ClosePopupAction TargetName="authorPopup" />

0 commit comments

Comments
 (0)