Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sophia smart contract language #5787

Open
marc0olo opened this issue Feb 15, 2022 · 5 comments
Open

Add Sophia smart contract language #5787

marc0olo opened this issue Feb 15, 2022 · 5 comments
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist

Comments

@marc0olo
Copy link

Language name

Sophia

URL of example repository

URL of syntax highlighting grammar

Most popular extensions

  • .aes

Detected language

N/A

@marc0olo marc0olo added Add Language Good First Issue This is a great opportunity to start contributing to Linguist labels Feb 15, 2022
@marc0olo
Copy link
Author

marc0olo commented Feb 15, 2022

@lildude we want to provide a bounty for our community to develop this. I am currently not sure if we have 200 usages of the extension across different github repositories.

assuming somebody provides a valid PR according to the contribution guidelines - would you merge it?

@marc0olo marc0olo changed the title Sophia Add Sophia smart contract language Feb 15, 2022
@lildude
Copy link
Member

lildude commented Feb 15, 2022

Possibly. We've temporarily got different requirements as detailed in #5756 so provided usage meets those requirements, it'll be merged.

@marc0olo
Copy link
Author

Thanks for the quick answer @lildude. It's a bit hard for me to figure that out. Not sure if we fulfill those requirements. Ideally we know that before we start working on it (or even promise a bounty to our community).

All I can say is that we are around for many years now and that Sophia is going to stay to all (a)eternity 😎

We're just getting started and GitHub syntax highlighting is a basic requirement IMO.

If possible it would be nice to get a statement if it's going to be merged before somebody starts working on it. Personally I am struggling with analyzing all the repos.

@marc0olo
Copy link
Author

can we get this confirmed somehow? 😬 🙌 that would be awesome @lildude

@lildude
Copy link
Member

lildude commented Feb 22, 2022

I can't tell you for sure until I take the time to assess the current usage, which will really depend on what you attempt to submit in the PR. I won't assess what hasn't been submitted.

Review the criteria in #5756 and make a judgment call for yourself.

I've also just shipped v7.19.0 yesterday (deployed today) and won't be making another release for at least a month or two which might be plenty time for your usage to grow from insufficient now (if this is the case) to sufficient then. All already submitted PRs are assessed for popularity as I prepare each release.

@lildude lildude linked a pull request Sep 1, 2022 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants