Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork table should show mirror count instead of branch count #192

Open
sutterj opened this issue Jun 19, 2024 · 5 comments
Open

Fork table should show mirror count instead of branch count #192

sutterj opened this issue Jun 19, 2024 · 5 comments
Labels
enhancement New feature or request high priority high impact improvements and fixes

Comments

@sutterj
Copy link
Contributor

sutterj commented Jun 19, 2024

Is your feature request related to a problem?

Having the branch count for the fork isn't really relevant information. It would be more helpful to show the count of mirrors.

Describe the solution you'd like

The table should be updated to show the count of mirrors.

Describe alternatives you've considered

No response

Additional context

No response

@sutterj sutterj added the enhancement New feature or request label Jun 19, 2024
@ahpook
Copy link
Contributor

ahpook commented Jun 19, 2024

Big +1 on this

Sorry for the ignorant question - how does the app currently differentiate, on a given fork, between branches that are just regular branches and branches that map to mirrors?

@sutterj
Copy link
Contributor Author

sutterj commented Jun 19, 2024

The current branch count is just a query on the total number of branches it has (regardless of relationship). The design had branches and I just went with it without really thinking about it. We can (maybe--not sure of query limitations) leave the branch count (if it's at all useful) and only count branches that are associated with mirrors and then add the mirror count or we can replace it with mirror count.

@ahpook
Copy link
Contributor

ahpook commented Jun 19, 2024

Definitely in favor of replacing the branch count with mirror count. I think the design just had that because it was using the format of the repo list table from this view or someplace similar ...

I'm wondering what it is that knows about & maintains the association between branches and mirrors, I didn't think there was a data store in the app yet

@sutterj
Copy link
Contributor Author

sutterj commented Jun 19, 2024

We use a custom property on the mirror repo to mark what fork it came from. The query to list the mirrors goes and finds all the repos in the org that have a custom property with the fork org/name in it. The original functionality was to store the fork org/name in the mirror repo's description.

@ahpook
Copy link
Contributor

ahpook commented Jun 19, 2024

Ahh gotcha, thanks for the explanation 👍

@ahpook ahpook added the high priority high impact improvements and fixes label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority high impact improvements and fixes
Projects
None yet
Development

No branches or pull requests

2 participants