Skip to content

Commit 698fbab

Browse files
committed
chore: always do curls in release tests
previously they were only enabled if the extended flag was set, to try to reduce the amount of time it took. But without curls we are not really testing external peerings, so we will have to live with it. Also increase a little the time limit for ci jobs to compensate. Signed-off-by: Emanuele Di Pascale <emanuele@githedgehog.com>
1 parent d7f8e73 commit 698fbab

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/ci.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ jobs:
221221
needs:
222222
- test
223223
- builds
224-
timeout-minutes: 120
224+
timeout-minutes: 150
225225

226226
strategy:
227227
fail-fast: false
@@ -479,7 +479,7 @@ jobs:
479479
needs:
480480
- test
481481
- builds
482-
timeout-minutes: 210
482+
timeout-minutes: 250
483483

484484
strategy:
485485
fail-fast: false
@@ -572,7 +572,7 @@ jobs:
572572
- name: Setup tmate session for debug
573573
if: ${{ failure() && github.event_name == 'workflow_dispatch' && inputs.debug_enabled }}
574574
uses: mxschmitt/action-tmate@v3
575-
timeout-minutes: 120
575+
timeout-minutes: 150
576576
with:
577577
limit-access-to-actor: true
578578

pkg/hhfab/release.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1395,10 +1395,11 @@ func makeTestCtx(kube kclient.Client, opts SetupVPCsOpts, workDir, cacheDir stri
13951395
PingsCount: 3,
13961396
IPerfsSeconds: 3,
13971397
IPerfsMinSpeed: 8200,
1398+
CurlsCount: 1,
13981399
}
13991400
if rtOpts.Extended {
1400-
testCtx.tcOpts.CurlsCount = 1
14011401
testCtx.tcOpts.IPerfsSeconds = 10
1402+
testCtx.tcOpts.CurlsCount = 3
14021403
}
14031404
testCtx.wipeBetweenTests = wipeBetweenTests
14041405
testCtx.extName = extName

0 commit comments

Comments
 (0)