feat(mgmt): strong typing for derived interface names

Linux interface names have strict rules.
These rules are captured and enforced by the `InterfaceName` type.

This commit switches the type of the generated interface names to indicate this to downstream consumers (including the VPC manager).

To be clear, these constraints are absolutely accounted for already in the generated string.  We just need the types to catch up.

Signed-off-by: Daniel Noland <daniel@githedgehog.com>

Author: daniel-noland

mgmt/src/processor/confbuild.rs

@@ -90,7 +90,7 @@ fn vpc_ipv4_import_configuration(vpc: &Vpc) -> (RouteMap, Vec<PrefixList>, Vec<S
         /* update route-map */
         let entry = RouteMapEntry::new(seq, MatchingPolicy::Permit)
             .add_match(RouteMapMatch::Ipv4AddressPrefixList(plist.name.clone()))
-            .add_match(RouteMapMatch::SrcVrf(p.remote_id.vrf_name()));
+            .add_match(RouteMapMatch::SrcVrf(p.remote_id.vrf_name().to_string()));
         rmap.add_entry(entry);
         seq += 10;
 
@@ -104,7 +104,7 @@ fn vpc_ipv4_import_configuration(vpc: &Vpc) -> (RouteMap, Vec<PrefixList>, Vec<S
 fn vpc_ipv4_imports(vpc: &Vpc) -> VrfImports {
     let mut imports = VrfImports::new().set_routemap(&vpc.import_route_map_ipv4());
     for p in vpc.peerings.iter() {
-        imports.add_vrf(&p.remote_id.vrf_name());
+        imports.add_vrf(p.remote_id.vrf_name().as_ref());
     }
     imports
 }

mgmt/src/processor/namegen.rs

@@ -6,22 +6,23 @@
 #![allow(unused)]
 
 use crate::models::external::overlay::vpc::{Vpc, VpcId};
+use net::interface::InterfaceName;
 
 impl VpcId {
-    pub(crate) fn vrf_name(&self) -> String {
-        format!("{self}-vrf")
+    pub(crate) fn vrf_name(&self) -> InterfaceName {
+        InterfaceName::try_from(format!("{self}-vrf")).unwrap_or_else(|_| unreachable!())
     }
-    pub(crate) fn bridge_name(&self) -> String {
-        format!("{self}-bri")
+    pub(crate) fn bridge_name(&self) -> InterfaceName {
+        InterfaceName::try_from(format!("{self}-bri")).unwrap_or_else(|_| unreachable!())
     }
-    pub(crate) fn vtep_name(&self) -> String {
-        format!("{self}-vtp")
+    pub(crate) fn vtep_name(&self) -> InterfaceName {
+        InterfaceName::try_from(format!("{self}-vtp")).unwrap_or_else(|_| unreachable!())
     }
 }
 
 impl Vpc {
     pub(crate) fn vrf_name(&self) -> String {
-        self.id.vrf_name()
+        self.id.vrf_name().to_string()
     }
     pub(crate) fn import_route_map_ipv4(&self) -> String {
         format!("RM-IMPORT-{}", self.name.to_uppercase())