-
Notifications
You must be signed in to change notification settings - Fork 143
trace2: fix tracing when NO_PTHREADS is defined #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Teach trace2 TLS code to not rely on pthread_getspecific() when NO_PTHREADS is defined. Instead, always assume the context data of the main thread. Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
/submit |
Submitted as pull.222.git.gitgitgadget@gmail.com |
On the Git mailing list, Jeff King wrote (reply to this):
|
On the Git mailing list, Jeff Hostetler wrote (reply to this):
|
On the Git mailing list, Jeff King wrote (reply to this):
|
On the Git mailing list, Jeff Hostetler wrote (reply to this):
|
On the Git mailing list, Duy Nguyen wrote (reply to this):
|
On the Git mailing list, Jeff King wrote (reply to this):
|
On the Git mailing list, Jeff Hostetler wrote (reply to this):
|
On the Git mailing list, Junio C Hamano wrote (reply to this):
|
This branch is now known as |
This patch series was integrated into pu via git@bf58bab. |
This patch series was integrated into pu via git@17a74a1. |
This patch series was integrated into pu via git@9a1430e. |
This patch series was integrated into next via git@849c491. |
This patch series was integrated into pu via git@e955580. |
This patch series was integrated into pu via git@90f2d88. |
This patch series was integrated into next via git@90f2d88. |
This patch series was integrated into master via git@90f2d88. |
Closed via 90f2d88. |
This commit addresses the problem reported in:
https://public-inbox.org/git/92cfdf43-8841-9c5a-7838-dda995038908@jeffhostetler.com/T/#mbaf8069f6d1bc18d5a02d3682a1f9282f5547ea9
As Duy suggested, pthread_getspecific() just returns NULL when NO_PTHREADS
is defined. And pthread_setspecific() silently does not nothing. So this problem was
hidden from view.
I have to wonder if we should update pthread_*specific() to call BUG() when
NO_PTHREADS is defined as a way to catch unguarded usages easier or make
this issue more clear.