Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format.outputDirectory should be based on the top of the repository #247

Open
Denton-L opened this issue May 31, 2019 · 2 comments
Open

format.outputDirectory should be based on the top of the repository #247

Denton-L opened this issue May 31, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Denton-L
Copy link
Member

Currently, if one has format.outputDirectory set, the output directory will be relative to wherever they've run the command, not the top of the repository. We should make it relative to the Git repository instead so that users don't end up creating patches in unintended locations.

Or maybe the current behaviour is desired and we should just force users to use an absolute path if they don't want this to happen. This requires discussion.
@weekly-digest weekly-digest bot mentioned this issue Jun 2, 2019
Closed
@Denton-L
Copy link
Member Author

An experimental implementation of this: https://github.com/Denton-L/git/tree/experimental/format-output-relative-gitdir

@Denton-L
Copy link
Member Author

Submission here: https://public-inbox.org/git/9422e4225143b2b908bd1fed9a510b9333bf34a2.1577191015.git.liu.denton@gmail.com/

@Denton-L Denton-L added the enhancement New feature or request label Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Denton-L