Skip to content

Commit

Permalink
Merge branch 'tb/mergetool-from-config'
Browse files Browse the repository at this point in the history
* tb/mergetool-from-config:
  git gui: add directly calling merge tool from configuration
  • Loading branch information
j6t committed Nov 9, 2024
2 parents 2864e85 + 8ff65c7 commit 4925501
Showing 1 changed file with 19 additions and 2 deletions.
21 changes: 19 additions & 2 deletions lib/mergetool.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,25 @@ proc merge_resolve_tool2 {} {
}
}
default {
error_popup [mc "Unsupported merge tool '%s'" $tool]
return
set tool_cmd [get_config mergetool.$tool.cmd]
if {$tool_cmd ne {}} {
if {([string first {[} $tool_cmd] != -1) || ([string first {]} $tool_cmd] != -1)} {
error_popup [mc "Unable to process square brackets in \"mergetool.%s.cmd\" configuration option.
Please remove the square brackets." $tool]
return
} else {
set cmdline {}
foreach command_part $tool_cmd {
lappend cmdline [subst -nobackslashes -nocommands $command_part]
}
}
} else {
error_popup [mc "Unsupported merge tool '%s'.
To use this tool, configure \"mergetool.%s.cmd\" as shown in the git-config manual page." $tool $tool]
return
}
}
}

Expand Down

0 comments on commit 4925501

Please sign in to comment.