Skip to content
This repository was archived by the owner on Apr 16, 2021. It is now read-only.
This repository was archived by the owner on Apr 16, 2021. It is now read-only.

General comments - minor fixes #7

Open
@Nanoseb

Description

@Nanoseb

After a quick read here are things I see you can improve:

  • You are using version control, so there is no need for a folder containing older version of your script, use git tags instead
  • You should indent your code, it makes it way easier to read
  • I am not sure I see the point of the 4s sleep but adding a non useful loading time
  • You should put double quotes when ever you use a variable. Here, if you send a message like ; rm -rf /*, it is going to get executed at line 30 (and maybe 40 too).
  • Use https://www.shellcheck.net/ to check for common mistakes

If you have more precise questions, feel free to ask them

Metadata

Metadata

Assignees

Labels

documentationImprovements or additions to documentation

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions