This repository was archived by the owner on Jan 18, 2021. It is now read-only.
Modified declaration file #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…caused linting errors in Typescript
kelvinbell
commented
Oct 17, 2018
| @@ -18,22 +18,20 @@ declare namespace sprLib { | |||
| interface FileInfoOptions { | |||
| version?: number; | |||
| } | |||
| class file { | |||
There was a problem hiding this comment.
Removed these classes. Added IFile interface and file function to replace the 'file' class. This was repeated in the other classes.
kelvinbell
commented
Oct 22, 2018
| @@ -89,6 +89,7 @@ declare namespace sprLib { | |||
| function site(siteUrl?: string): ISite; | |||
|
|
|||
| interface UserOptions { | |||
| baseUrl?: string; | |||
There was a problem hiding this comment.
'baseUrl' was in the documentation, but not in the declaration file.
kelvinbell
commented
Oct 22, 2018
| @@ -98,7 +99,7 @@ declare namespace sprLib { | |||
| interface IUser { | |||
| info(): Promise<Object>; | |||
| groups(): Promise<Object[]>; | |||
| profile(arrProfileKeys: Object): Object; | |||
| profile(arrProfileKeys?: Object): Promise<Object>; | |||
There was a problem hiding this comment.
Returned a promise for the profile func.
gitbrent
approved these changes
Oct 23, 2018
|
Excellent work, thanks @kelvinbell ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting errors were produced in Typescript because of the declared classes in the declaration file. Changed the classes file, folder, list, site, and user to functions and added respective interfaces.