Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See which tags / branches containing this commit #656

Open
gitblit opened this issue Aug 12, 2015 · 6 comments
Open

See which tags / branches containing this commit #656

gitblit opened this issue Aug 12, 2015 · 6 comments

Comments

@gitblit
Copy link
Collaborator

gitblit commented Aug 12, 2015

Originally reported on Google Code with ID 360

Would be nice to see somewhere on the Commit-Detail-Page which tags contain that commit
as the command "$ git tag --contains deadbeefcafebabe" does.

This would be very helpful to determine with which Build a specific fix got shipped.

Reported by jalbersdorfer on 2014-01-20 15:20:45

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

I have implemented this in a fork of gitblit - maybe you want to have a look on it.
I'm not fully comfortable with the solution of finding out wheter a RevCommit is a
descendant of another RevCommit. - maybe you have a better Idea there.

https://github.com/jalbersdorfer/gitblit/commit/753191b0bc4d2f44669896910fb8ef4a5c9309e3

Reported by jalbersdorfer on 2014-01-21 12:21:18

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

I'll take a look later this week.  At a quick glance, you are doing it the way I would
do it... isMergedInto.

Reported by James.Moger on 2014-01-21 15:50:56

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

isMergedInto wasn't working for me. - But maybe I've just misused it.
Because of this I've written that checkDescendant() Method which does the walk itself.
I think isMergedInto doesn't respect multiple parents in case of merges and therefore
it does not always find the way down to the right Tags.

Reported by jalbersdorfer on 2014-01-21 16:24:29

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

Hi, are there any news on this?

Reported by jalbersdorfer on 2014-03-28 07:31:12

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

I did look at your code back in January, but I haven't done anything with it yet.  I've
been focused on other aspects of Gitblit: tickets and now SSH - both of which are fairly
large features with many, many details.  If you want to move this forward I suggest
creating a pull request.  I would prefer to also see branches, not just tags, but it's
been a while since I looked at it and that may be too expensive.

Reported by James.Moger on 2014-03-28 11:52:35

@gitblit
Copy link
Collaborator Author

gitblit commented Aug 12, 2015

Reported by James.Moger on 2014-10-22 12:13:45

  • Status changed: Accepted
  • Labels added: Milestone-1.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants