diff --git a/.github/actions/deploy-to-github-pages/action.yml b/.github/actions/deploy-to-github-pages/action.yml index 1713f45990..d11464ed94 100644 --- a/.github/actions/deploy-to-github-pages/action.yml +++ b/.github/actions/deploy-to-github-pages/action.yml @@ -122,9 +122,8 @@ runs: - name: check for broken links id: lychee - uses: lycheeverse/lychee-action@d4128702eae98bbc5ecf74df0165a8156c80920a # until an official version is out that includes https://github.com/lycheeverse/lychee/pull/1422 + uses: lycheeverse/lychee-action@v2 with: - lycheeVersion: nightly # until an official version includes https://github.com/lycheeverse/lychee/pull/1422 args: >- --offline --fallback-extensions html @@ -144,7 +143,8 @@ runs: fail: false failIfEmpty: false # needed because its default overrides `fail = false` - - name: ${{ env.lychee_exit_code != '0' && 'maybe close' || 'open or update' }} link checker issue + - name: ${{ env.lychee_exit_code != '0' && 'open or update' || 'maybe close' }} link checker issue + if: env.lychee_exit_code != '' uses: actions/github-script@v7 with: github-token: ${{ inputs.github-token }} @@ -198,6 +198,7 @@ runs: run: sudo sh -c 'echo "185.199.108.153 git-scm.com" >>/etc/hosts' - name: Run Playwright tests shell: bash + id: playwright env: PLAYWRIGHT_TEST_URL: ${{ steps.pages.outputs.base_url }} run: | @@ -206,9 +207,10 @@ runs: https://*|http://git-scm.com) ;; # okay, leave as-is http://*) PLAYWRIGHT_TEST_URL="https://${PLAYWRIGHT_TEST_URL#http://}";; esac && + echo "result=$PLAYWRIGHT_TEST_URL" >>$GITHUB_OUTPUT && npx playwright test --project=chrome - uses: actions/upload-artifact@v4 - if: always() + if: always() && steps.playwright.outputs.result != '' with: name: playwright-report path: playwright-report/ \ No newline at end of file diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e723882fa3..7513da65b5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -60,9 +60,8 @@ jobs: - name: check for broken links id: lychee - uses: lycheeverse/lychee-action@d4128702eae98bbc5ecf74df0165a8156c80920a # until an official version is out that includes https://github.com/lycheeverse/lychee/pull/1422 + uses: lycheeverse/lychee-action@v2 with: - lycheeVersion: nightly # until an official version includes https://github.com/lycheeverse/lychee/pull/1422 args: >- --offline --fallback-extensions html @@ -80,11 +79,14 @@ jobs: - name: Install @playwright/test run: npm install @playwright/test - name: Run Playwright tests + id: playwright env: PLAYWRIGHT_TEST_URL: http://localhost:5000/ - run: npx playwright test --project=chrome + run: | + echo "result=$PLAYWRIGHT_TEST_URL" >>$GITHUB_OUTPUT && + npx playwright test --project=chrome - uses: actions/upload-artifact@v4 - if: always() + if: always() && steps.playwright.outputs.result != '' with: name: playwright-report path: playwright-report/ \ No newline at end of file