Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap add and modify colors, update icon for Big Sur #729

Merged
merged 2 commits into from
Jan 3, 2021

Conversation

jason5122
Copy link
Contributor

@jason5122 jason5122 commented Dec 20, 2020

I swapped the colors associated with added files and modified files, as discussed in #703. This is because virtually every other Git client has this color scheme and it seems to make more sense than adding being blue and modifying being green. Unfortunately, it seems the icon file sizes are larger after editing them in GIMP (~300 bytes → ~3 KB) — I'm not too sure why this is the case. If someone is more experienced with this, please feel free to make changes!

I've also updated the icons for Big Sur using the icon set provided by @mdznr in #723.

Screenshot

Screen Shot 2020-12-20 at 12 51 19 PM

Replacement icons

Normal

icon_file_a

icon_file_m

2x

icon_file_a@2x

icon_file_m@2x

I agree to the contributor agreement.

@jason5122 jason5122 changed the title Swap add and modify colors (blue <-> green) Swap add and modify colors, update icon for Big Sur Dec 21, 2020
@lucasderraugh
Copy link
Collaborator

Thanks, @jasonhan-vassar! I think out of all the changes this color change one is going to be what I hear the most feedback from 😅. I think it is appropriate though and probably what most people would expect at least using GitHub. I'll review it today and get this 1.2 release out before for Christmas.

@lucasderraugh lucasderraugh merged commit 78b0bdf into git-up:master Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants