Run more closure tests; Compatible handling of +/- Infinity in fromNumber, see dcodeIO#50

Author: dcodeIO

dist/long.js

@@ -139,7 +139,7 @@ Long.fromInt = fromInt;
  * @inner
  */
 function fromNumber(value, unsigned) {
-    if (isNaN(value) || !isFinite(value))
+    if (isNaN(value))
         return unsigned ? UZERO : ZERO;
     if (unsigned) {
         if (value < 0)

dist/long.js.map

@@ -23,15 +23,17 @@ goog.provide("goog.global");
 
 goog.provide("goog.asserts");
 
+var assert = require("assert");
 goog.asserts.assert = function(condition, opt_message, var_args) {
-  if (!condition)
-    throw Error("Assertion error: " + opt_message + " " + Array.prototype.slice.call(arguments, 2));
+  assert(condition, opt_message, Array.prototype.slice.call(arguments, 2));
 };
 
 global.assertEquals = function(expected, actual) { goog.asserts.assert(expected === actual); }
 
 global.assertTrue = function(value) { goog.asserts.assert(value === true); }
 
+global.assertNotNull = function(value) { goog.asserts.assert(value !== null); }
+
 goog.provide("goog.reflect");
 
 goog.reflect.cache = function(cacheObj, key, valueFn, opt_keyFn) {

src/long.js

@@ -1,24 +1,29 @@
 require("./base");
 
+function runTests() {
+  Object.keys(goog.global).forEach(function(key) {
+    if (/^test/.test(key) && typeof goog.global[key] === "function") {
+      console.log("- " + key);
+      var fn = goog.global[key];
+      delete goog.global[key];
+      try {
+        fn();
+      } catch (e) {
+        console.log("\nERROR: " + e + "\n");
+        process.exitCode = 1;
+      }
+    }
+  });
+}
+
 require("./initial/long");
 require("./initial/long_test");
 
 console.log("Testing initial goog.math.long.js ...");
-Object.keys(goog.global).forEach(function(key) {
-  if (typeof goog.global[key] === "function") {
-    console.log("Running '" + key + "' ...");
-    goog.global[key]();
-  }
-});
-goog.global = {};
+runTests();
 
 require("./recent/long");
 require("./recent/long_test");
 
 console.log("\nTesting (more) recent goog.math.long.js ...");
-Object.keys(goog.global).forEach(function(key) {
-  if (typeof goog.global[key] === "function") {
-    console.log("Running '" + key + "' ...");
-    goog.global[key]();
-  }
-});
+runTests();

tests/goog/base.js

@@ -1615,10 +1615,35 @@ function testIsStringInRange() {
   }
 }
 
-// goog.global['testIsStringInRange' + i] = testIsStringInRange(i);
-
 // Regression test for
 // https://github.com/google/closure-library/pull/498
 function testBase36ToString() {
   assertEquals('zzzzzz', goog.math.Long.fromString('zzzzzz', 36).toString(36));
 }
+
+// BEGIN MONKEY PATCH
+
+// long.js doesn't have getZero etc. but instead ZERO
+if (goog.math.Long.ZERO) {
+  goog.math.Long.getZero = function() { return this.ZERO; };
+  goog.math.Long.getOne = function() { return this.ONE; };
+  goog.math.Long.getMaxValue = function() { return this.MAX_VALUE; };
+  goog.math.Long.getMinValue = function() { return this.MIN_VALUE; };
+}
+
+// the test runner can't just 'see' these functions, so add them explicitly
+[
+  testToFromBits,
+  testToFromInt,
+  testToFromNumber,
+  testIsZero,
+  testIsNegative,
+  testIsOdd,
+  testNegation,
+  testAdd,
+  testSubtract,
+  testMultiply,
+  testBase36ToString
+].forEach(function(fn) { goog.global[fn.name] = fn; });
+
+// END MONKEY PATCH