Fix update classification logic to return nil for invalid formats and downgrades

Author: andrew

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## [Unreleased]
 
 - Auto-upgrade outdated database schemas instead of erroring
+- Fix `outdated` command suggesting downgrades when current version is newer than registry
 
 ## [0.9.0] - 2026-01-14
 

lib/git/pkgs/commands/outdated.rb

@@ -115,6 +115,7 @@ def run
             next if current == latest
 
             update_type = classify_update(current, latest)
+            next unless update_type
             next if @options[:major_only] && update_type != :major
             next if @options[:minor_only] && update_type == :patch
 
@@ -129,7 +130,7 @@ def run
             return
           end
 
-          type_order = { major: 0, minor: 1, patch: 2, unknown: 3 }
+          type_order = { major: 0, minor: 1, patch: 2 }
           outdated.sort_by! { |o| [type_order[o[:update_type]], o[:name]] }
 
           if @options[:format] == "json"
@@ -173,16 +174,15 @@ def classify_update(current, latest)
           current_parts = parse_version(current)
           latest_parts = parse_version(latest)
 
-          return :unknown if current_parts.nil? || latest_parts.nil?
+          return nil if current_parts.nil? || latest_parts.nil?
+          return nil if (current_parts <=> latest_parts) >= 0
 
           if latest_parts[0] > current_parts[0]
             :major
           elsif latest_parts[1] > current_parts[1]
             :minor
-          elsif latest_parts[2] > current_parts[2]
-            :patch
           else
-            :unknown
+            :patch
           end
         end
 

test/git/pkgs/test_outdated_command.rb

@@ -51,11 +51,26 @@ def test_classify_update_with_v_prefix
     assert_equal :minor, cmd.classify_update("v1.0.0", "1.1.0")
   end
 
-  def test_classify_update_unknown_format
+  def test_classify_update_invalid_format
     cmd = Git::Pkgs::Commands::Outdated.new([])
 
-    assert_equal :unknown, cmd.classify_update("abc", "def")
-    assert_equal :unknown, cmd.classify_update("", "1.0.0")
+    assert_nil cmd.classify_update("abc", "def")
+    assert_nil cmd.classify_update("", "1.0.0")
+  end
+
+  def test_classify_update_downgrade_returns_nil
+    cmd = Git::Pkgs::Commands::Outdated.new([])
+
+    assert_nil cmd.classify_update("2.0.0", "1.0.0")
+    assert_nil cmd.classify_update("1.5.0", "1.4.0")
+    assert_nil cmd.classify_update("1.0.5", "1.0.4")
+    assert_nil cmd.classify_update("2.0.0", "1.5.0")
+  end
+
+  def test_classify_update_same_version_returns_nil
+    cmd = Git::Pkgs::Commands::Outdated.new([])
+
+    assert_nil cmd.classify_update("1.0.0", "1.0.0")
   end
 
   def test_parse_version