Add ARM64/aarch64 support, add cleanup logic

Author: dennisameling

action.yml

@@ -11,7 +11,7 @@ inputs:
     default: 'minimal'
   architecture:
     required: false
-    description: 'The architecture of the SDK: x86_64 or i686'
+    description: 'The architecture of the SDK: x86_64, i686 or aarch64. Note that "aarch64" uses the x86_64 SDK, but adds "clangarm64" to the path.'
     default: 'x86_64'
   msys:
     required: false
@@ -32,3 +32,4 @@ inputs:
 runs:
   using: 'node16'
   main: 'dist/index.js'
+  post: 'dist/index.js'

dist/index.js

@@ -2,8 +2,15 @@ import * as core from '@actions/core'
 import {mkdirp} from './src/downloader'
 import {restoreCache, saveCache} from '@actions/cache'
 import process from 'process'
-import {spawnSync} from 'child_process'
-import {getViaGit} from './src/git'
+import {spawn, spawnSync} from 'child_process'
+import {getArtifactMetadata, getViaGit} from './src/git'
+import * as fs from 'fs'
+import * as coreCommand from '@actions/core/lib/command'
+
+const flavor = core.getInput('flavor')
+const architecture = core.getInput('architecture')
+const architectureToDownload =
+  architecture === 'aarch64' ? 'x86_64' : architecture
 
 async function run(): Promise<void> {
   try {
@@ -13,12 +20,14 @@ async function run(): Promise<void> {
       )
       return
     }
-    const flavor = core.getInput('flavor')
-    const architecture = core.getInput('architecture')
+
     const verbose = core.getInput('verbose')
     const msysMode = core.getInput('msys') === 'true'
 
-    const {artifactName, download, id} = await getViaGit(flavor, architecture)
+    const {artifactName, download, id} = await getViaGit(
+      flavor,
+      architectureToDownload
+    )
     const outputDirectory = core.getInput('path') || `C:/${artifactName}`
     let useCache: boolean
     switch (core.getInput('cache')) {
@@ -61,7 +70,22 @@ async function run(): Promise<void> {
       }
     }
 
-    const mingw = architecture === 'i686' ? 'MINGW32' : 'MINGW64'
+    let mingw = ''
+
+    switch (architecture) {
+      case 'i686':
+        mingw = 'MINGW32'
+        break
+      case 'x86_64':
+        mingw = 'MINGW64'
+        break
+      case 'aarch64':
+        mingw = 'CLANGARM64'
+        break
+      default:
+        core.setFailed(`Invalid architecture ${architecture} specified`)
+    }
+
     const msystem = msysMode ? 'MSYS' : mingw
 
     const binPaths = [
@@ -109,9 +133,84 @@ async function run(): Promise<void> {
     })) {
       ln(`/dev/${linkPath}`, `/proc/self/${target}`)
     }
+
+    if (msystem === 'CLANGARM64') {
+      // ARM64 dependencies aren't included yet in the Git for Windows SDK. Ask Pacman to install them.
+      await installArm64Dependencies(outputDirectory)
+    }
   } catch (error) {
     core.setFailed(error instanceof Error ? error.message : `${error}`)
   }
 }
 
-run()
+async function installArm64Dependencies(
+  outputDirectory: string
+): Promise<void> {
+  core.info('Installing CLANGARM64 dependencies...')
+  mkdirp(`${outputDirectory}/clangarm64`)
+  fs.appendFileSync(
+    `${outputDirectory}/etc/pacman.conf`,
+    `
+    [clangarm64]
+    Server = https://mirror.msys2.org/mingw/clangarm64/`
+  )
+
+  const child = spawn('pacman.exe', [
+    '-Sy',
+    '--noconfirm',
+    'base-devel',
+    'mingw-w64-clang-aarch64-openssl',
+    'mingw-w64-clang-aarch64-zlib',
+    'mingw-w64-clang-aarch64-curl',
+    'mingw-w64-clang-aarch64-expat',
+    'mingw-w64-clang-aarch64-libiconv',
+    'mingw-w64-clang-aarch64-toolchain',
+    'mingw-w64-clang-aarch64-pcre2',
+    'mingw-w64-clang-aarch64-libssp'
+  ])
+
+  child.stdout.on('data', data => {
+    core.info(data)
+  })
+
+  child.stderr.on('data', data => {
+    core.error(data)
+  })
+
+  return new Promise((resolve, reject) => {
+    child.on('error', error => reject(error))
+    child.on('close', status =>
+      status === 0
+        ? resolve()
+        : reject(new Error(`Process exited with status code ${status}`))
+    )
+  })
+}
+
+function cleanup(): void {
+  const {artifactName} = getArtifactMetadata(flavor, architectureToDownload)
+  const outputDirectory = core.getInput('path') || `C:/${artifactName}`
+
+  core.info(`Cleaning up ${outputDirectory}...`)
+  fs.rmSync(outputDirectory, {recursive: true, force: true})
+  core.info(`Finished cleaning up ${outputDirectory}.`)
+}
+
+/**
+ * Indicates whether the POST action is running
+ */
+export const isPost = !!process.env['STATE_isPost']
+
+// Publish a variable so that when the POST action runs, it can determine it should run the cleanup logic.
+// This is necessary since we don't have a separate entry point.
+if (!isPost) {
+  coreCommand.issueCommand('save-state', {name: 'isPost'}, 'true')
+}
+
+// If the POST action is running, we cleanup our artifacts
+// Inspired from https://github.com/actions/checkout/blob/2541b1294d2704b0964813337f33b291d3f8596b/src/state-helper.ts#L67-L71
+if (isPost) {
+  cleanup()
+} else {
+  run()
+}