Correct fscanf formatting string for I64u values

[weakcamel]

Signed-off-by: Waldek Maleska w.maleska@gmail.com

[weakcamel]

As discussed at #52 (comment)

[dscho]

@weakcamel are you still interested in this issue? If so, I would be very interested in your opinion about my suggestion.

[weakcamel]

I am and yes, I like the idea.
At first I wondered if defining those constants wouldn't interfere with including inttypes.h after someone includes the git-compat-utils.h or mingw.h
The former already requires the standard header - so no problem there.
The latter being mingw/windows specific, I can't imagine someone to include it otherwise.

I'll go ahead and prepare a patch.

[dscho]

To be sure, I did not suggest including any header there, just introducing a block

#ifndef SCNuMAX
#define SCNuMAX PRIuMAX
#endif`

not anything more...

[weakcamel]

Done (finally!). Thank you for you patience.
Let me know if I should squash it or of course if you see ny problems.

[dscho]

Thanks! I added a comment with a question and would like to request a squash and rebase followed by a force-push to finalize this Pull Request.

[dscho]

Checked and it's not enough - the warnings are back - SCNuMAX is back at "llu". Can't yet tell where it comes from, I just had a moment to look into it

You can check by inserting #define SCNuMAX PRIuMAX right before weakcamel@4b096a0#diff-29b0a2def034550470a8eb7e8b673403L225 and compiling (gcc will complain that the constant has been redefined and tell you where the original definition came from).

[weakcamel]

Thank you!

Well, the definition comes from .. git-compat-utils.h
So either we should include mingw.h before the, or repeat the OS-specific magic in it.
What do you think?

[dscho]

Hmm. I wonder why it works for PRIuMAX, but not SCNuMAX: after all, we #define PRIuMAX in compat/mingw.h and git-compat-util.h sees that and does not redefine it. In my mind, at that stage, SCNuMAX should not yet be #defined, but PRIuMAX should be, correctly, so it should work. I guess I'll need to dig into this myself...

[weakcamel]

They're both at 'llu'. I've added #pragma message in git-compat-utils.h and in general, without loading definitions from <inttypes.h> they're wrong on 32-bits.

$ rm builtin/gc.o && make builtin/gc.o
    CC builtin/gc.o
In file included from ./builtin.h:4:0,
                 from builtin/gc.c:13:
./git-compat-util.h:263:9: note: #pragma message: llullu
 #pragma message PRIuMAX SCNuMAX
         ^
...

[dscho]

In my tests, the SCNuMAX constant was actually defined correctly if I skipped the change to compat/mingw.h, so I mangled your patch. Hopefully you do not mind!

[weakcamel]

I do not mind and all. I'm glad you did. Thank you!