minor monitor-components improvements #3983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
reviewed
Aug 14, 2022
|
@rimrul what's the status on this? Do you need me to assist? |
As we've discovered with Git 2.37.1, our workflow to inform us about component updates can miss embargoed git releases, since GitHub usues the tag creation date as the publication date for their feeds. To prevent similar issues with other components in the future, let's increase the time span we look at for new feed items, as discussed in git-for-windows#3948 (comment) Signed-off-by: Matthias Aßhauer <mha1993@live.de>
rimrul
force-pushed
the
monitor-components-improvements
branch
2 times, most recently
from
fc53bad to
53251c8
Compare
The `environment` keyword makes GitHub Actions believe this is a deployment environment [1], but we aren't deploying anything in this workflow. Having a "deployment" workflow on a frequent schedule causes some pull requests like [2] to become filled with thousands of "dscho deployed temporarily to monitor-components" messages. This was originally intended to allow this workflow to open issues, but we can instead just specify that the workflow should run with permissions to create issues and then use the generated access token. [1] https://docs.github.com/en/actions/deployment/targeting-different-environments/using-environments-for-deployment [2] git-for-windows#3948 Signed-off-by: Matthias Aßhauer <mha1993@live.de>
rimrul
force-pushed
the
monitor-components-improvements
branch
from
53251c8 to
c8dc900
Compare
|
Should be good now. |
dscho
approved these changes
Oct 31, 2022
|
Procedural note: since we need to rebuild cURL (after the dependency nghttp2 was built with a different DLL file name), I want to wait for https://dev.azure.com/git-for-windows/git/_build/results?buildId=108304&view=logs&j=275f1d19-1bd8-5591-b06b-07d489ea915a to finish, then kick off the two |
Zeze1184
added a commit
to https-github-com-Zeze1184/git
that referenced
this pull request
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.